Build Nix derivations using Crane #50
Open
+159
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qqwy
commented
Jan 30, 2026
|
|
||
| done_count = done_count.saturating_add(1); | ||
| if done_count % 50 == 0 { | ||
| if done_count.is_multiple_of(50) { |
Contributor
Author
There was a problem hiding this comment.
Introduced in a newer Rust version, so now Clippy fix adds this.
Qqwy
commented
Jan 30, 2026
| # dependency on the Python packages that we override. | ||
| # In our case cachix > ghc > shpinx > Python libraries. | ||
| pythonChannable = prev.python312.override { packageOverrides = pythonOverlay; }; | ||
| python = prev.python312.override { packageOverrides = pythonOverlay; }; |
Contributor
Author
There was a problem hiding this comment.
For this one package, it is cleaner to give it a generic name. This allows dependents to override what python version is used (with or without specifying it in an overlay).
Qqwy
commented
Jan 30, 2026
| description = "lightweight batch processing queue for heavy loads" | ||
| repository = "https://github.com/channable/opsqueue" | ||
| license = "MIT" | ||
| include=["opsqueue_example_database_schema.db"] |
Contributor
Author
There was a problem hiding this comment.
Boyscout rule: Newer cargo was complaining about this not being set in the right place.
Contributor
Author
|
@OpsBotPrime merge |
Contributor
|
Your merge request has been denied, because merging on Fridays is not recommended. To override this behaviour use the command |
… the overlay Before it was only used in the devshell; now it is also used when compiling the binary targets.
- Make usage of `crane` an implementation detail; - When building with Nix, people get to customize what `rustToolchain` is used, by either setting that in the overlay or directly overriding it when using `callPackage`. - Compile opsqueue_python also with Crane (+ Maturin). - Document how the Nix Crane<->Maturin setup works - Bump Rust version in rust-toolchain.toml from 1.85 to 1.92 This is now also the version used when building with Nix! - Boyscout rule: Fix warning about unused Cargo.toml lib.include key - Boyscout rule: Disable integration test timeouts, to test speed of the Nix-based integration suite run on CI
…eue Python library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
biomefrompre-commitas we do not have any useful JSON that is worth being formattedrust-toolchain.tomlalso in Nix.rustPlatform, it secretly under the hood does not use the givenrustToolchainbut picks whatever other deps (in this case one of the opentelemetry Python libs depends on a cryptography lib which also uses maturin) decided to use as Rust version. A very strange and footgunny interaction of Nix<->Python<->Rust.