Draft
Conversation
Contributor
There was a problem hiding this comment.
The PR introduces an aggregated JaCoCo coverage report module with a few correctness issues: the Maven phase ordering for the merge/check executions doesn't guarantee the merged .exec file exists before the coverage check runs, the dataFileExcludes filter targets a path that never contains .exec files, and the integration-tests dependency carries an explicit version that should be managed centrally. These should be addressed before merging.
PR Bot Information
Version: 1.17.99 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
85339b70-1bd2-11f1-84f6-1f9a6a0e1284 - Event Trigger:
pull_request.opened
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Aggregated JaCoCo Coverage Report Module
Chore
🔧 Introduces a dedicated
coverage-reportMaven module that aggregates JaCoCo coverage data from both unit tests and integration tests into a single combined report for SonarQube analysis.Changes
coverage-report/pom.xml: New Maven module (cds-feature-attachments-coverage-report) that:.execfiles from unit tests (cds-feature-attachments) and integration tests (integration-tests/srv) into a singlejacoco-merged.execreport-aggregateintegration-tests/srv/pom.xml: Added the JaCoCoprepare-agentexecution so integration tests produce ajacoco.execfile that can be merged into the aggregate report.pom.xml:coverage-reportmodule in the root build.cds-feature-attachments-coverage-reportfrom Maven Central publishing.skip-integration-testsprofile comment to reflect the new module exclusion..github/actions/scan-with-sonar/action.yml:-plbuild to a fullmvn clean verify -ntp -Bacross all modules.coverage-report/target/site/jacoco-aggregate/jacoco.xmlreport.sonar.coverage.jacoco.xmlReportPaths..pipeline/config.yml: Addedcoverage-report/target/site/jacoco-aggregate/jacoco.xmlto thesonar.coverage.jacoco.xmlReportPathsconfiguration so SonarQube picks up the combined coverage data.📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!
PR Bot Information
Version:
1.17.99| 📖 Documentation | 🚨 Create Incident | 💬 Feedbackanthropic--claude-4.6-sonnet85339b70-1bd2-11f1-84f6-1f9a6a0e1284pull_request.opened