feat: configurable Metro port#79
Open
mfazekas wants to merge 1 commit intocallstackincubator:mainfrom
Open
Conversation
|
@mfazekas is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
35d6904 to
6b5d353
Compare
6b5d353 to
841c099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
metroPortconfig option (defaults to 8081) so harness tests can run on a non-default Metro port. This enables running independent harness sessions across git worktrees and avoids conflicts when port 8081 is already in use.RCT_jsLocationviaxcrun simctl spawn ... defaults writedebug_http_hostSharedPreferences viaadb shell run-as+ sets upadb reversefor the configured portUsage
Or via CLI:
Limitations
RCT_jsLocationremotely).Test plan
metroPort: 8082while 8081 is occupiedmetroPort: 8082while 8081 is occupiedMetro port 8081 is not availablewhen occupied