Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e9b8cc0a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| app: positionals[0], | ||
| url: positionals[1], | ||
| activity: flags.activity, | ||
| relaunch: flags.relaunch, | ||
| ...buildSelectionOptions(flags), |
There was a problem hiding this comment.
open is documented to accept --save-script (and still inherits global --no-record), but this client-backed branch only forwards app/url/activity/relaunch plus selection fields, so those recording flags are silently dropped before the daemon request. In practice, open <app> --save-script will not enable session script capture (the session handler gates recording on req.flags.saveScript), and --no-record cannot suppress logging for this path.
Useful? React with 👍 / 👎.
src/cli-client-commands.ts
Outdated
| } | ||
|
|
||
| if (command === 'screenshot') { | ||
| const result = await client.capture.screenshot({ path: positionals[0] }); |
There was a problem hiding this comment.
The screenshot command supports --out (src/utils/command-schema.ts), but this call only forwards the positional path, so agent-device screenshot --out <path> loses the requested destination when routed through the typed client. That changes existing CLI behavior for scripted runs that rely on --out to control artifact location.
Useful? React with 👍 / 👎.
thymikee
force-pushed
the
codex/typed-daemon-client
branch
from
5d7ec1a to
ff3ba4a
Compare
thymikee
force-pushed
the
codex/typed-daemon-client
branch
from
ff3ba4a to
9721d47
Compare
1 participant
Summary
Add a published typed TypeScript client for core daemon operations and route the covered CLI commands through that client.
Keep scope within the daemon client/CLI/session handler surface; touched files: 12.
Simplify the initial implementation by returning device identifiers directly from
open, removing the extrasession_listround-trip, extracting client-backed CLI handling into its own module, and excluding test declarations from the package build.Validation
pnpm typechecknode --test src/__tests__/client.test.ts src/__tests__/cli-diagnostics.test.ts src/daemon/handlers/__tests__/session.test.tspnpm test:smokepnpm buildKnown gap:
pnpm test:unitstill hits the pre-existing pending-promise failure insrc/daemon/__tests__/http-server.test.ts.