Open
Conversation
d95f090 to
f56b57d
Compare
f56b57d to
2afa209
Compare
…id deps to be properly resolved by Gradle when consumed
…checked cast compilation warnings
…ediation mechanisms
ffdea99 to
9390219
Compare
…perly initialize React Native
…s implemented in brownie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our brownfield plugin has previously worked with Expo, but required manual setup. This PR provides an Expo config plugin to automate that, and a demo Expo application for testing. The plugin applies all the setup steps we described in brownfield's docs, automatically, during expo prebuild. Additionally:
Demo apps & CI have been adjusted:
CLI has been adjusted to run the Expo prebuild if expo is both: detected installed & explicitly listed in the package.json so as not to produce false positives in monorepo setups.
Finally, the CLI is updated to work seamlessly with Expo projects.
Screenshots
Android CLI screenshots
iOS CLI screenshots
Android app: Expo variant
Android app: vanilla variant
Test plan
CI green.