-
Notifications
You must be signed in to change notification settings - Fork 11.5k
feat: companion add missing advanced event type #26594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and description toggle from companion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 9 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="companion/components/event-type-detail/utils/buildPartialUpdatePayload.ts">
<violation number="1" location="companion/components/event-type-detail/utils/buildPartialUpdatePayload.ts:754">
P2: Default value changed from `false` to `true` for `sendTranscriptionEmails`. When `original.calVideoSettings` is undefined, the old code defaulted to `false` but the new code defaults to `true`. This could cause false-positive change detection and unnecessary API updates for existing event types where this was never explicitly set.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
companion/components/event-type-detail/utils/buildPartialUpdatePayload.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="companion/app/(tabs)/(event-types)/event-type-detail.tsx">
<violation number="1" location="companion/app/(tabs)/(event-types)/event-type-detail.tsx:1122">
P1: The `isDirty` check order prevents creating new event types. When `id === "new"`, `eventTypeData` is `null` (since `parseInt("new", 10)` is `NaN`), so `if (!eventTypeData) return false` executes before the `id === "new"` check. The Create button will always be disabled.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Summary by cubic
Added missing advanced event-type settings in Companion and made them editable in the Advanced tab. This enables proper configuration and handling for cancelling/rescheduling, transcription emails, interface language, and optimized slots.
Written for commit a7e0f2d. Summary will update on new commits.