Skip to content

Conversation

@dhairyashiil
Copy link
Member

@dhairyashiil dhairyashiil commented Jan 8, 2026

Summary by cubic

Added missing advanced event-type settings in Companion and made them editable in the Advanced tab. This enables proper configuration and handling for cancelling/rescheduling, transcription emails, interface language, and optimized slots.

  • New Features
    • Extended EventType and payloads to support API V2 fields (disableCancelling/disableRescheduling, calVideoSettings, interfaceLanguage, showOptimizedSlots) with legacy compatibility and partial updates.
    • Updated Advanced tab and detail screen to load/save these settings, adding toggles and a language picker; Save is now disabled until changes are made on edits and remains enabled for new event types.

Written for commit a7e0f2d. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Jan 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
api-v2 Ignored Ignored Preview Jan 10, 2026 0:25am
cal Ignored Ignored Jan 10, 2026 0:25am
cal-companion Ignored Ignored Preview Jan 10, 2026 0:25am
cal-eu Ignored Ignored Jan 10, 2026 0:25am

@dhairyashiil dhairyashiil marked this pull request as ready for review January 9, 2026 07:26
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 9, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="companion/components/event-type-detail/utils/buildPartialUpdatePayload.ts">

<violation number="1" location="companion/components/event-type-detail/utils/buildPartialUpdatePayload.ts:754">
P2: Default value changed from `false` to `true` for `sendTranscriptionEmails`. When `original.calVideoSettings` is undefined, the old code defaulted to `false` but the new code defaults to `true`. This could cause false-positive change detection and unnecessary API updates for existing event types where this was never explicitly set.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="companion/app/(tabs)/(event-types)/event-type-detail.tsx">

<violation number="1" location="companion/app/(tabs)/(event-types)/event-type-detail.tsx:1122">
P1: The `isDirty` check order prevents creating new event types. When `id === "new"`, `eventTypeData` is `null` (since `parseInt("new", 10)` is `NaN`), so `if (!eventTypeData) return false` executes before the `id === "new"` check. The Create button will always be disabled.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@volnei volnei merged commit d865f6c into main Jan 9, 2026
38 of 39 checks passed
@volnei volnei deleted the feat/companion-add-missing-advanced-event-type branch January 9, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync ready-for-e2e size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants