Add BinaryColumnToVarbinaryRector for TYPE_VARBINARY migration#389
Draft
dereuromark wants to merge 2 commits into6.xfrom
Draft
Add BinaryColumnToVarbinaryRector for TYPE_VARBINARY migration#389dereuromark wants to merge 2 commits into6.xfrom
dereuromark wants to merge 2 commits into6.xfrom
Conversation
Adds a rector rule to help users upgrade to CakePHP 6.0 where
TYPE_VARBINARY was added:
- `addColumn('col', 'binary', ['fixed' => true])` becomes
`addColumn('col', 'binary', [])` (remove fixed attribute)
- `addColumn('col', 'binary', [...])` becomes
`addColumn('col', 'varbinary', [...])` (change type)
See: cakephp/cakephp#19258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Rector rule to help users upgrade migration files for CakePHP 6.0 where
TYPE_VARBINARYwas added.Related: cakephp/cakephp#19258
Transformations
Fixed-length binary (with
fixedattribute):Variable-length binary (without
fixedattribute):Notes
addColumn()calls in migration filesfixedattribute is removed sincebinarytype is now always fixed-lengthfixed => trueare converted tovarbinarytype