Add rector rules for cakephp/authentication 4.x upgrade

[dereuromark]

Summary

Adds rector rules to automate the Authentication plugin 3.x to 4.x migration:

• Class renames:

  • Authentication\UrlChecker\CakeRouterUrlChecker → Authentication\UrlChecker\DefaultUrlChecker
  • Authentication\UrlChecker\DefaultUrlChecker (framework-agnostic) → Authentication\UrlChecker\GenericUrlChecker
  • Authentication\Plugin → Authentication\AuthenticationPlugin

• Method removal:

  • AuthenticationService::loadIdentifier() - removed in 4.x

Usage

bin/cake upgrade rector --rules authentication40

Or in custom rector config:

use Cake\Upgrade\Rector\Set\CakePHPSetList;

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->sets([CakePHPSetList::AUTHENTICATION_40]);
};

Not automated

Some changes require manual intervention and are documented in the upgrade guide:

1. Constant relocations - CREDENTIAL_USERNAME/CREDENTIAL_PASSWORD moved from AbstractIdentifier to PasswordIdentifier/LdapIdentifier
2. IdentifierCollection removal - Identifiers are now configured per-authenticator
3. MultiUrlChecker - Auto-detection removed, requires explicit configuration

Related

• Authentication 4.x PR: 4.x major: Remove deprecations, fix up MultiChecker. authentication#748
• Upgrade guide: https://github.com/cakephp/authentication/blob/4.x/docs/en/upgrade-3-to-4.rst

[markstory]

If you run this more than once will all the UrlChecker references end up as StringUrlChecker?

[dereuromark]

Yeah, that is not really idempotent right now

I dont have any great ideas other than: Marker comment

  // @upgraded-authentication-4.0
  use Authentication\UrlChecker\DefaultUrlChecker;

and then skip it.

This could be a bit difficult with inline usage of FQCN.

Alternative: file-level docblock

  <?php
  /**
   * @rector-upgraded authentication40
   */

once we run it.

[dereuromark]

Or: we just drop the old Default one rename.
And only rename the cake to default one.

No one outside of cake would use the upgrade tool here, and the few cases of people using the "external" over the cake router internal one would be almost irrelevant I assume.

[markstory]

Skipping the rename on the existing default checker could work. I agree that there are likely few references to it in application code.