Enable gc feature by default#12805
Open
tolumide-ng wants to merge 1 commit intobytecodealliance:mainfrom
Open
Conversation
|
|
||
| [features] | ||
| # WASMTIME_FEATURE_LIST | ||
| default = ["gc"] |
Member
There was a problem hiding this comment.
Oh for this the default feature lives here instead which includes gc, so I think it's reasonable to just from [dependencies]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
c-apicrate currently enables thegcfeature on itswasmtimedependency, even though it exposes agcfeature to control this behaviour. This prevents downstream users from disablinggc, sinceCargo.tomldoesn't allow overriding it. However, structs likeRootScopeare only available whengcis enabled. Removing it from default features, without other options, would break internal implementations.Changes
gcfeature via the wasmtime-c-api crate by default.gcfeature for thewasmtimedependency inc-api, thus enabling downstream users to specify this behaviour.Closes #12783