fix: move wit_* packages into wit-bindgen dir#18
Closed
asteurer wants to merge 1 commit intobytecodealliance:mainfrom
Closed
fix: move wit_* packages into wit-bindgen dir#18asteurer wants to merge 1 commit intobytecodealliance:mainfrom
asteurer wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
Contributor
|
Oh you know I hadn't actually considered moving wit. I was more concerned about any go referenced from the root for go-modules. My main advice is that since you aren't the legacy tool, you should pick the preferred package names. One option to consider, place public api's in
vs |
Contributor
Author
|
Moving in a different direction (see go-pkg) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For clarity, I prefer to house the
wit_*files in a shared directory.@ricochet You had mentioned that you might like to move the
witdirectory ingo-modulestocomponentize-goand store thewit_*files there. I'm worried about confusion arising from mixing new code with legacy code. I figured that it would be clearer to people that thewit_*files are associated withwit-bindgenif we organize them as such. I'm definitely open to discussion, so let me know what you think 😃.Note: I relied on an LLM's suggestions for how to handle moving the
wit_*files into thewit-bindgendirectory. It's entirely possible that thedocs/wit-bindgensetup isn't going to work haha