fix: send extra headers only for openrouter provider#87
Closed
Hopsken wants to merge 1 commit intobubbuild:mainfrom
Closed
fix: send extra headers only for openrouter provider#87Hopsken wants to merge 1 commit intobubbuild:mainfrom
Hopsken wants to merge 1 commit intobubbuild:mainfrom
Conversation
Author
|
Just notice that there is a big ongoing refactoring, closing this to avoid conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix provider-specific header routing in model calls to avoid passing OpenRouter metadata to incompatible providers (for example Gemini).
What Changed
ModelRunner._chatheader logic:openrouter:*-> passextra_headers(HTTP-Referer,X-Title)vertexai:*-> passhttp_options.headers(existing behavior)tests/test_model_runner.pyto match the stricter routing behavior.Why
Gemini rejects unknown config fields like
extra_headers, causing runtime validation errors.Routing headers only where needed prevents cross-provider incompatibilities.
Verification
uv run pytest -q tests/test_model_runner.py12 passedImpact
BUB_MODEL=gemini:...