devenv: Add tmt and nushell

[cgwalters]

Prep for #55 among others.

Assisted-by: OpenCode (Sonnet 4.5)

[gemini-code-assist]

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the development environment by incorporating nushell, a modern and powerful shell, and tmt, a robust testing framework. These additions aim to provide developers with more advanced tools for scripting and comprehensive test management, thereby improving overall productivity and the quality assurance process within the devcontainer. The changes also include updated documentation to reflect these new capabilities and ensure proper validation through dedicated self-tests.

Highlights

• Nushell Integration: The modern shell, Nushell (nu), has been integrated into the development environment, including its installation and version management via fetch-tools.sh.
• TMT Testing Framework: The tmt (Test Management Tool) framework has been added to the development environment, with its installation handled via pip3 for Debian-based containers and package manager for c10s.
• Enhanced Devcontainer Documentation: The README.md has been updated to provide a clearer description of the devcontainer's purpose, explicitly listing included tools like nu and tmt.
• Comprehensive Self-Tests: New self-tests have been introduced in devenv-selftest.sh to verify the correct installation and basic functionality of both nushell and tmt.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• devenv/Containerfile.c10s
  • Introduced nushellversion as a build argument.
  • Updated the fetch-tools.sh execution to pass the nushellversion.
• devenv/Containerfile.debian
  • Introduced nushellversion as a build argument.
  • Updated the fetch-tools.sh execution to pass the nushellversion.
  • Added installation of tmt with provision-virtual using pip3.
• devenv/README.md
  • Updated the description to clarify the goal of the devcontainer for tools like VSCode remote containers, Codespaces, and devpod.
  • Explicitly listed nu (nushell) and tmt as included tools.
• devenv/devenv-init.sh
  • Improved script robustness by adding set -euo pipefail.
  • Modified the userns-setup call, removing exec.
• devenv/devenv-selftest.sh
  • Added self-tests for nushell to verify its installation and basic functionality.
  • Added self-tests for tmt, including command existence, version check, and a minimal test plan setup and discovery.
• devenv/fetch-tools.sh
  • Enforced the presence of nushellversion environment variable.
  • Implemented logic to fetch and install nushell binaries from GitHub releases, handling different architectures.
• devenv/packages-c10s.txt
  • Added tmt to the list of packages for the c10s container.
• devenv/packages-debian.txt
  • Added python3-pip to the list of packages for the debian container.

Activity

• No specific activity (comments, reviews, etc.) was provided for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds tmt and nushell to the development environment containers, along with corresponding tests and documentation updates. However, it introduces several instances of insecure shell variable handling in build scripts and Containerfiles, specifically regarding unquoted build arguments and derived variables, which could lead to command injection. Additionally, there are opportunities to improve the robustness of shell scripts through better error handling and temporary resource cleanup.