Update CUDA/ROCm setup tests#1899
Open
sstamenk wants to merge 3 commits intobitsandbytes-foundation:mainfrom
Open
Update CUDA/ROCm setup tests#1899sstamenk wants to merge 3 commits intobitsandbytes-foundation:mainfrom
sstamenk wants to merge 3 commits intobitsandbytes-foundation:mainfrom
Conversation
matthewdouglas
added
CUDA Setup
ROCm
CUDA
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated backend-specific setup handling and tests for CUDA/ROCm library selection. The change makes
get_cuda_bnb_library_path()fail fast when the wrong override variable is used (BNB_ROCM_VERSIONon CUDA orBNB_CUDA_VERSIONon ROCm), improves the warning/error guidance, and refreshes the evaluator tests to useBNB_BACKENDwith clearer CUDA/ROCm coverage.Removed the
test_get_rocm_bnb_library_path_rocm_override_takes_priorityunit-test as it doesn't provide much utility.This PR is a subset of the changes originally proposed in #1888