Open
Conversation
gemenerik
reviewed
Feb 24, 2026
Member
gemenerik
left a comment
gemenerik
left a comment
There was a problem hiding this comment.
Before merging this PR, we first need to merge the required changes in the cflib repository. This PR should then be updated to pin cflib to that specific cflib commit (in pyproject.toml). In an ideal world we would do a small cflib release instead of pinning to a commit, but given our release process... this is how we've handled it in the past. When we do a full release of cfclient, we will make sure to release cflib first and update the dependency to point to that release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this cflib PR, some platform commands (
send_arming_requestandsend_recovery_request) are moved fromplatformservice.pytosupervisor.py.This PR updates these commands in the cfclient's side. Should be merged after the firmware PR and the cflib PR are merged.