feat(Promotions): PROMO-1240 Added field maximum_allowed_discount_amount#1110
Closed
bc-anshumishra wants to merge 1 commit intomainfrom
Closed
feat(Promotions): PROMO-1240 Added field maximum_allowed_discount_amount#1110bc-anshumishra wants to merge 1 commit intomainfrom
bc-anshumishra wants to merge 1 commit intomainfrom
Conversation
Comment on lines
+1092
to
+1093
| maximum_allowed_discount_amount: | ||
| $ref: '#/components/schemas/MaximumAllowedDiscountAmount' |
Contributor
There was a problem hiding this comment.
Suggested change
| maximum_allowed_discount_amount: | |
| $ref: '#/components/schemas/MaximumAllowedDiscountAmount' | |
| maximum_allowed_discount_amount: | |
| $ref: '#/components/schemas/Money' | |
| description: The maximum monetary value .... |
| pattern: '[0-9]+(\.[0-9]+)?' | ||
| type: string | ||
| description: The maximum monetary value that can be applied as a discount. The application of this maximum depends on the discount type`:` | ||
| Discount on shipping`:` Maximum discount total applies to ALL shipping destinations combined. Maximum total is divide evenly amongst all shipping destinations. |
Contributor
There was a problem hiding this comment.
probably can make this PR based on Jasper's PR for shipping discount: #1100 so we can show the proof for shipping discount as well ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROMO-1240
What changed?
Testing
Release notes draft
Anything else?
ping @bc-anshumishra