fix: validate basename avatar aspect ratio and clear stale todo#2923
Open
Dark-Brain07 wants to merge 1 commit intobase:masterfrom
Open
fix: validate basename avatar aspect ratio and clear stale todo#2923Dark-Brain07 wants to merge 1 commit intobase:masterfrom
Dark-Brain07 wants to merge 1 commit intobase:masterfrom
Conversation
|
@Dark-Brain07 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
createImageBitmapto ensure uploaded avatars are roughly square (ratio 0.8 - 1.25), fulfilling a TODO in usernames.ts.// TODO: add discord linkcomment in Footer.tsx as the link was already present.Notes to reviewers
asyncto allow for image bitmap creation, which is necessary for checking dimensions.useEffectin UsernameAvatarField now includes a mounted check to prevent state updates on unmounted components during the async validation.How has it been tested?
Have you tested the following pages?
BaseWeb