[v2] Add tagging support for the s3 mb command

[aemous]

Issues:

• [Feature Request] Add tagging support to s3 #2458

Description of changes:

• Added support for specifying tags on bucket creation for the aws s3 mb command.
• Added functional tests for testing the new feature.
• Added a new aws s3 mb command example using the new flag.

Description of test:

• Ran a successful build-and-validate workflow.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[AndrewAsseily]

Tiny nit: double space in "when the region name" on this comment.

[AndrewAsseily]

Looks good otherwise! Approving 🏆

[aemous]

Good catch, revised.

[AndrewAsseily]

[kdaily]

Question: If the flag can only hold one tag, and you can specify it multiple times, then why is the name the plural tags instead of tag?

[aemous]

Question: If the flag can only hold one tag, and you can specify it multiple times, then why is the name the plural tags instead of tag?

Do you have a strong preference for the singular form? I'm open to feedback on this.

My reason for choosing plural is because the flag forms a list of tags (i.e. argparse represents the flag as a list). It may be a bit weird for it to be named tag but in code it is a list of multiple tags.

[kdaily]

Fair enough, not that strongly. However, the proposed syntax does deviate from other existing commands besides s3 that have tagging support that use --tags Key1=Value1 Key2=Value2 syntax. Just confirming we considered that in the design here.

#9981

[AndrewAsseily]

Fair enough, not that strongly. However, the proposed syntax does deviate from other existing commands besides s3 that have tagging support that use --tags Key1=Value1 Key2=Value2 syntax. Just confirming we considered that in the design here.

#9981

When thinking about this earlier, I found that --tags (plural) is overwhelmingly the convention across the CLI, though I don't feel too strongly about either in this case.
On the Key=Value syntax, the design doc covers this. The shorthand syntax parser has character limitations (e.g., @ is reserved for key@=file:// loading), which would break for valid S3 tag keys. The Key Value format with nargs=2 avoids that issue

[ashovlin]

Can you add a changelog entry and a new example of using it?

[aemous]

Can you add a changelog entry and a new example of using it?

I've added both in latest revision.