Skip to content

Conversation

@yogeshchoudhary147
Copy link
Contributor

Changes

Updates the README documentation to reflect modern Angular (v19+) best practices:

  • ✅ Replace deprecated APP_INITIALIZER with provideAppInitializer()
  • ✅ Show provideAuth0() as the primary configuration method
  • ✅ Move AuthModule.forRoot() examples to collapsible "Legacy Approach" sections
  • ✅ Update dynamic configuration examples with proper imports and inject() usage
  • ✅ Maintain all existing explanations and important notes

Motivation

Addresses #672 - The documentation was showing deprecated patterns (APP_INITIALIZER) which are no longer recommended in Angular 19+. This update ensures developers see the modern functional approach first while still providing NgModule examples for those who need them.

Testing

  • Documentation is clear and accurate
  • Code examples are syntactically correct
  • Both modern and legacy approaches are documented

Related Issues

Fixes #672

- Replace deprecated APP_INITIALIZER with provideAppInitializer
- Show provideAuth0() as primary configuration method
- Move NgModule examples to collapsible legacy sections
- Update for Angular 19+ best practices

Fixes #672
@yogeshchoudhary147 yogeshchoudhary147 requested a review from a team as a code owner January 5, 2026 12:29
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally approved, wanted to request changes.

- Changed from 'For modern Angular applications (v19+)' to 'The recommended approach'
- provideAuth0() works from Angular 15+, not just 19+
- Addresses PR feedback from @frederikprijck
@frederikprijck frederikprijck merged commit a9eb19a into main Jan 5, 2026
8 of 9 checks passed
@frederikprijck frederikprijck deleted the docs/update-app-initializer-pattern branch January 5, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APP_INITIALIZER is deprecated

3 participants