gh-146230: Fix copy/paste mistake in binascii.c#1
Merged
ashutoshk314 merged 92 commits intoashutoshk314:mainfrom Mar 27, 2026
Merged
gh-146230: Fix copy/paste mistake in binascii.c#1ashutoshk314 merged 92 commits intoashutoshk314:mainfrom
ashutoshk314 merged 92 commits intoashutoshk314:mainfrom
Conversation
…gh-146229) Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h.
* Apply changes from importlib_metadata 8.9.0 * Suppress deprecation warning in fork.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Guido van Rossum <gvanrossum@gmail.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…`shell=True` (#138536) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…ey` (#146154) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…cking of such tuples (GH-144300) Co-authored-by: Ken Jin <kenjin4096@gmail.com>
Add base32 encoder and decoder functions implemented in C to the binascii module and use them to greatly improve the performance and reduce the memory usage of the existing base32 codec functions in the base64 module.
…ad (GH-145267) Base64 decoder (see binascii.a2b_base64(), base64.b64decode(), etc) no longer ignores excess data after the first padded quad in non-strict (default) mode. Instead, in conformance with RFC 4648, it ignores the pad character, "=", if it is present before the end of the encoded data.
Use more regular code to handle reference counting in treebuilder_handle_end(). Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…-146178) Co-authored-by: Victor Stinner <vstinner@python.org>
Add `_SimpleCData._type_` docs. Add type codes to the summary table. Cross-link `struct`, `array`, and `ctypes`; throw in `numpy` too. (Anyone wanting to add a code should be aware of those.) Add `py_object`, and `VARIANT_BOOL` for completeness.
… file is missing. (#146234)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…eared_in_forked_child (#146330)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…Timed` (gh-146064) Add atomic loads in the slow path of PyMutex to increase the number of lock acquisitions per second that threads can make on a shared mutex.
…king (GH-145906) AttributeErrors raised in keys() or __getitem__() during dictionary unpacking ({**mymapping} or func(**mymapping)) are no longer masked by TypeError.
…46241) Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
Add more pickle tests: test also nested structures.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c0dcb3e0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+645
to
647
| extra=None, server=None, context=None): | ||
| return _ProactorSocketTransport(self, sock, protocol, waiter, | ||
| extra, server) |
There was a problem hiding this comment.
BaseEventLoop._create_connection_transport() and Server._start_serving() now pass an explicit context, but the Proactor implementation drops it here, so connection_made/connection_lost callbacks run in the ambient scheduling context instead of the captured connection/server context. On Windows this breaks the new contextvars-isolation behavior (for example when a server is created in one context and started/used in another), and makes Proactor semantics diverge from SelectorEventLoop.
Useful? React with 👍 / 👎.
Use uniform standard signature syntax in the tutorial and in the array and collections modules documentation.
…#146447) Modifies the iOS build script so that the clean target is more selective about what is cleaned, the test target has a valid fallback value for ci mode, and the cross-build directory can be customised.
Add --pythoninfo option to dump build information.
… iOS XCframeworks (#146499) Ensure that multi-arch libpython dylibs aren't copied into the app, and the standard lib is always found for framework post-processing.
Migrate the Apple/iOS XCframework build tools to the Platforms directory.
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
This reverts commit 68c7fad. It looks like on practice the __STDC_IEC_559__ doesn't indicate conformance to the standard. It can't be used to filter out tests or to give some promises in documentation. See discussion in the reverted PR thread: #138811 (comment)
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
If _PyErr_SetKeyError() is called with an exception set, it now replaces the current exception with KeyError (as expected), instead of setting a SystemError or failing with a fatal error (in debug mode).
…tail-calling interpreter (#146391) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Recognise *-gnu (after *-linux*) as GNU/Hurd for cross-compilation.
…be cleaned up by `_POP_TOP` be cleaned up by `_POP_TOP` (GH-146383)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a copy/paste mistake in binascii.c
Issue: python#146230