Open
Conversation
Skip uploading build cache to S3 when it exceeds the size limit. Configurable via APPPACK_MAX_CACHE_SIZE_GB environment variable (default: 7GB). Set to 0 to disable the limit entirely. Invalid or negative values fall back to the default with a warning.
ipmb
requested changes
Feb 12, 2026
| if val := os.Getenv(MaxCacheSizeEnvVar); val != "" { | ||
| parsed, err := strconv.Atoi(val) | ||
| if err != nil { | ||
| fmt.Printf("WARNING: Invalid %s value '%s', using default %dGB\n", MaxCacheSizeEnvVar, val, DefaultMaxCacheSizeGB) |
Member
There was a problem hiding this comment.
Can we use the logging system here instead of print?
| b.Log().Warn().Err(err).Msg("failed to calculate cache directory size") | ||
| } else if size > maxSize { | ||
| sizeMB := size / (1024 * 1024) | ||
| fmt.Printf("WARNING: Cache directory is %dMB, exceeding %dGB limit. Skipping cache upload.\n", sizeMB, maxGB) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Build caches can grow very large. Uploading caches over 7GB to S3 wastes time and storage.
Solution: Check cache directory size before uploading. Skip the upload if it exceeds the limit.
Changes:
Testing:
go test ./build/...All tests pass.