fix: use readlink(2) instead of realpath(3) to avoid autofs stalls invirtiofs paths#548
Open
Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Open
fix: use readlink(2) instead of realpath(3) to avoid autofs stalls invirtiofs paths#548Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a host directory under
/home/<user>/is bind-mounted into a container, any code that calledURL.resolvingSymlinksInPath()on a path inside that directory would stall for 5–10 seconds. macOS intercepts filesystem lookups under/home/through its autofs automounter when the code tried to resolve a symlink pointing there, macOS would attempt an automount that never succeeds, timing out after 5–10 seconds.The fix introduces a
rawSymlinkTarget()helper onURLthat usesreadlink(2)directly. This reads only the raw value stored in the symlink inode — no filesystem traversal, no autofs trigger.