Skip to content

[ZEPPELIN-6358] Remove anti-patterns of E2E and tidy test suite#5180

Open
dididy wants to merge 11 commits intoapache:masterfrom
dididy:tidy-e2e
Open

[ZEPPELIN-6358] Remove anti-patterns of E2E and tidy test suite#5180
dididy wants to merge 11 commits intoapache:masterfrom
dididy:tidy-e2e

Conversation

@dididy
Copy link
Contributor

@dididy dididy commented Mar 13, 2026

What is this PR for?

Applied the e2e-reviewer skill on the existing E2E suite. The skill does static analysis — it catches tests that can never actually fail, silent skips, swallowed errors in POM methods, that kind of thing.

Findings and fixes:

  • home-page-enhanced-functionality.spec.ts was mostly duplicating home-page-elements and home-page-note-operations → deleted and merged
  • toBeGreaterThanOrEqual(0) and toBeAttached() on static elements were always passing → replaced with assertions that can fail
  • if (isVisible) { expect() } patterns silently skip when something breaks → removed or converted to test.skip
  • Several POM methods had .catch(() => {}) with no comment → removed; kept the intentional ones and marked with // JUSTIFIED:
  • document.querySelector in page.evaluate() → swapped for Playwright locator API
  • Added aria-label / data-testid to action bar HTML; a few tests were breaking on DOM structure changes
  • Renamed a handful of tests whose names didn't match what they actually tested; dropped the ones that only called toBeVisible()

What type of PR is it?

Improvement
Refactoring

Todos

What is the Jira issue?

ZEPPELIN-6358

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant