[ZEPPELIN-6358] Remove anti-patterns of E2E and tidy test suite#5180
Open
dididy wants to merge 11 commits intoapache:masterfrom
Open
[ZEPPELIN-6358] Remove anti-patterns of E2E and tidy test suite#5180dididy wants to merge 11 commits intoapache:masterfrom
dididy wants to merge 11 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Applied the
e2e-reviewerskill on the existing E2E suite. The skill does static analysis — it catches tests that can never actually fail, silent skips, swallowed errors in POM methods, that kind of thing.Findings and fixes:
home-page-enhanced-functionality.spec.tswas mostly duplicatinghome-page-elementsandhome-page-note-operations→ deleted and mergedtoBeGreaterThanOrEqual(0)andtoBeAttached()on static elements were always passing → replaced with assertions that can failif (isVisible) { expect() }patterns silently skip when something breaks → removed or converted totest.skip.catch(() => {})with no comment → removed; kept the intentional ones and marked with// JUSTIFIED:document.querySelectorinpage.evaluate()→ swapped for Playwright locator APIaria-label/data-testidto action bar HTML; a few tests were breaking on DOM structure changestoBeVisible()What type of PR is it?
Improvement
Refactoring
Todos
What is the Jira issue?
ZEPPELIN-6358
How should this be tested?
Screenshots (if appropriate)
Questions: