Missing Length if format was set in fabricate_with_old_api

[scw00]

Missing Length if format was set in fabricate_with_old_api

The resulting_buffer_length will be zero if format was set. Then ats free the return's buffer and close connection directly.

[scw00]

test script

function do_remap()
    ts.http.set_resp(403, "403 Forbidden")
    return 0
end

response

> POST HTTP://www.scw.com/bjh HTTP/1.0
> User-Agent: curl/7.35.0
> Host: www.scw.com
> Accept: */*
> Proxy-Connection: Keep-Alive
> Content-Length: 65721
> Content-Type: multipart/form-data; boundary=------------------------eb5732dcfe4fef73
> 
} [data not shown]
* HTTP 1.0, assume close after body
< HTTP/1.0 403 Forbidden
< Date: Mon, 19 Jun 2017 01:57:26 GMT
< Via: http/1.1 ubuntu-linux (ApacheTrafficServer/8.0.0 [c s f ])
< Server: ATS/8.0.0
< Cache-Control: no-store
< Content-Type: text/html
< Content-Language: en
< Content-Length: 13
< 
{ [data not shown]
* Closing connection 0

[bryancall]

[approve ci]

[zwoop]

@scw00 do you happen to know what version(s) of ATS this affects? We need this in 7.1.0 ?

[scw00]

No, it is only in 7.2 and 8.0 since #1299 merged.

[SolidWallOfCode]

The original use of plain_flag is very odd - it's initialized to false and then never changed. Presumably it was intended for this use?