fix(operator): prevent KeywordSearch operator from running with an empty keywords field#4277
Open
seongjinyoon wants to merge 1 commit intoapache:mainfrom
Open
fix(operator): prevent KeywordSearch operator from running with an empty keywords field#4277seongjinyoon wants to merge 1 commit intoapache:mainfrom
seongjinyoon wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
@Xiao-zhen-Liu Please review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The
Keyword Searchoperator could be executed even when thekeywordsfield was left empty.The fix adds a minimum length for the
keywordsfield marking the operator as invalid when the field is empty.Before:
After:
Any related issues, documentation, discussions?
#3046
How was this PR tested?
Manually tested.
Was this PR authored or co-authored using generative AI tooling?
Revised using Claude Code.