fix(backend): prevent workflow cloning when user revokes own access#4153
Merged
Xiao-zhen-Liu merged 5 commits intoapache:mainfrom Jan 14, 2026
Merged
Conversation
Contributor
Author
|
@Xiao-zhen-Liu Sorry, this is the correct PR. |
Xiao-zhen-Liu
approved these changes
Jan 12, 2026
Contributor
Xiao-zhen-Liu
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
Contributor
|
@seongjinyoon Please fix the test cases. |
Contributor
Author
|
@Xiao-zhen-Liu Thank you for the review. I have made the according changes. Please merge the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes a bug where workflow were cloned when users revoked their own access to a shared workflow while having it open in the workspace.
Bug:
When a user revoked their own access while editing a shared workflow, the frontend's auto-persist would continue to save changes. The backend's
persistWorkflowmethod would receive these save requests from a user who no longer has access, and create a new workflow.Changes Made:
Backend (
WorkflowResource.scala):persistWorkflow()method to distinguish between:Frontend (
ShareAccessComponent):verifyRevokeAccess()method that shows a confirmation modal before revoking access.revokeAccess()private and updated it to return a flag when user revokes their own access.Frontend (
MenuComponent):Frontend (
share-access.component.html):verifyRevokeAccess()instead ofrevokeAccess()to trigger confirmation popup.Before:
Before.mov
After:
After.mov
Any related issues, documentation, discussions?
#4153
How was this PR tested?
Manually tested.
Was this PR authored or co-authored using generative AI tooling?
No.