Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the load-fakedata.py script to work with a changed internal API. The add_issue method signature was changed to generate issue IDs (iid) internally rather than requiring them as a parameter.
Changes:
- Updated
load-fakedata.pyto calladd_issuewithout manually generating IIDs - Applied code formatting improvements across multiple files (whitespace, line breaks, quote consistency)
- Enhanced CI workflow reliability by adding
apt-get updatebefore package installation
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| v3/server/bin/load-fakedata.py | Removed manual IID generation; now calls add_issue with new signature |
| v3/server/bin/create-election.py | Code formatting improvements (quotes, spacing, blank lines) |
| v3/steve/election.py | Removed blank lines and reformatted method calls |
| v3/tests/run_stv.py | Removed unnecessary parentheses and fixed spacing |
| v3/steve/vtypes/stv.py | Removed trailing whitespace and reformatted list comprehension |
| v3/server/pages.py | Fixed comment formatting and reformatted logging statement |
| .github/workflows/type-tests.yml | Added apt-get update before installing dependencies |
| .github/workflows/linting.yml | Added apt-get update before installing dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal signature has been changed.
cc @gstein