Skip to content

Fix load-fakedata.py#64

Open
tisonkun wants to merge 3 commits intotrunkfrom
finetune
Open

Fix load-fakedata.py#64
tisonkun wants to merge 3 commits intotrunkfrom
finetune

Conversation

@tisonkun
Copy link
Member

@tisonkun tisonkun commented Feb 4, 2026

Internal signature has been changed.

cc @gstein

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the load-fakedata.py script to work with a changed internal API. The add_issue method signature was changed to generate issue IDs (iid) internally rather than requiring them as a parameter.

Changes:

  • Updated load-fakedata.py to call add_issue without manually generating IIDs
  • Applied code formatting improvements across multiple files (whitespace, line breaks, quote consistency)
  • Enhanced CI workflow reliability by adding apt-get update before package installation

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
v3/server/bin/load-fakedata.py Removed manual IID generation; now calls add_issue with new signature
v3/server/bin/create-election.py Code formatting improvements (quotes, spacing, blank lines)
v3/steve/election.py Removed blank lines and reformatted method calls
v3/tests/run_stv.py Removed unnecessary parentheses and fixed spacing
v3/steve/vtypes/stv.py Removed trailing whitespace and reformatted list comprehension
v3/server/pages.py Fixed comment formatting and reformatted logging statement
.github/workflows/type-tests.yml Added apt-get update before installing dependencies
.github/workflows/linting.yml Added apt-get update before installing dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant