[SPARK-52351][SQL] Fix T prefix detection after whitespace trimming in stringToTimestamp#55049
Open
xiaoxuandev wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-52351][SQL] Fix T prefix detection after whitespace trimming in stringToTimestamp#55049xiaoxuandev wants to merge 1 commit intoapache:masterfrom
xiaoxuandev wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
reviewed
Mar 27, 2026
| val parsedValue = b - '0'.toByte | ||
| if (parsedValue < 0 || parsedValue > 9) { | ||
| if (j == 0 && b == 'T') { | ||
| if (j == trimmedStart && b == 'T') { |
Member
There was a problem hiding this comment.
Should we also fix the Scaladoc above?
…n stringToTimestamp ### What changes were proposed in this pull request? Fix T prefix detection in parseTimestampString after whitespace trimming. The condition used hardcoded j == 0 instead of comparing against the trimmed start index, causing T-prefixed time strings with leading whitespace (e.g. " T23:17:50") to fail parsing. ### Why are the changes needed? Without this fix, timestamp strings like " T23:17:50" with leading whitespace before the T prefix are not parsed correctly, returning None instead of the expected timestamp. ### Does this PR introduce _any_ user-facing change? Yes. T-prefixed time strings with leading whitespace are now parsed correctly. ### How was this patch tested? Added test cases for: - Leading whitespace with T prefix - Leading whitespace with T prefix and time zone - Leading whitespace with year sign (+/-) ### Was this patch authored or co-authored using generative AI tooling? Yes, co-authored with Kiro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix T prefix detection in parseTimestampString after whitespace trimming. The condition used hardcoded j == 0 instead of comparing against the trimmed start index, causing T-prefixed time strings with leading whitespace (e.g. " T23:17:50") to fail parsing.
Why are the changes needed?
Without this fix, timestamp strings like " T23:17:50" with leading whitespace before the T prefix are not parsed correctly, returning None instead of the expected timestamp.
Does this PR introduce any user-facing change?
Yes. T-prefixed time strings with leading whitespace are now parsed correctly.
How was this patch tested?
Added test cases for:
Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Kiro.