RATIS-2430. Write snapshot to temporary path until finish#1372
Draft
devabhishekpal wants to merge 2 commits intoapache:masterfrom
Draft
RATIS-2430. Write snapshot to temporary path until finish#1372devabhishekpal wants to merge 2 commits intoapache:masterfrom
devabhishekpal wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Today when SnapshotInstallatioHandler#checkAndInstallSnapshot calls
state.installSnapshot(request)- it pauses the state machine viaServerState.installSnapshot().However this means that in case later checks fail or IO fails or any such scenario occurs, then there is no clear rollback option. Followers in this scenario can be left in a partial installation state.
One way to mitigate this is in appendChunk we can write to a temp file without pausing StateMachine. When this is done we can atomically apply the snapshot and reload the statemachine log.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2430
How was this patch tested?
Patch was tested using unit tests.