RATIS-2429. ratis-bom module fails to deploy due to missing distributionManagement configuration

[OneSizeFitsQuorum]

see https://issues.apache.org/jira/browse/RATIS-2429

[adoroszlai]

Nice catch, I missed following my own comment:

ratis/pom.xml

Lines 185 to 186 in 1433b4c

	<!-- Contains all shaded thirdparty dependencies; make sure to also update in ratis-bom/pom.xml -->
	<ratis.thirdparty.version>1.0.11</ratis.thirdparty.version>

[OneSizeFitsQuorum]

It was just an accidental discovery :)

[adoroszlai]

Should we copy from root POM both distributionManagement and the properties it refers to, as is?

ratis/pom.xml

Lines 36 to 47 in 1433b4c

	<distributionManagement>
	<repository>
	<id>${distMgmtStagingId}</id>
	<name>${distMgmtStagingName}</name>
	<url>${distMgmtStagingUrl}</url>
	</repository>
	<snapshotRepository>
	<id>${distMgmtSnapshotsId}</id>
	<name>${distMgmtSnapshotsName}</name>
	<url>${distMgmtSnapshotsUrl}</url>
	</snapshotRepository>
	</distributionManagement>

ratis/pom.xml

Lines 171 to 176 in 1433b4c

	<distMgmtSnapshotsId>apache.snapshots.https</distMgmtSnapshotsId>
	<distMgmtSnapshotsName>Apache Development Snapshot Repository</distMgmtSnapshotsName>
	<distMgmtSnapshotsUrl>https://repository.apache.org/content/repositories/snapshots</distMgmtSnapshotsUrl>
	<distMgmtStagingId>apache.staging.https</distMgmtStagingId>
	<distMgmtStagingName>Apache Release Distribution Repository</distMgmtStagingName>
	<distMgmtStagingUrl>https://repository.apache.org/service/local/staging/deploy/maven2</distMgmtStagingUrl>

[OneSizeFitsQuorum]

Currently, there are no properties in the ratis-bom, so I think the current style is consistent. I think it's both OK whether to change it or not.

[adoroszlai]

My concern is that if someone builds the project with custom repo (-DdistMgmtStagingUrl=... or similar), ratis-bom might unexpectedly get deployed to Apache. Copying the properties would prevent it, custom value would be applied to ratis-bom lke all other modules.

[OneSizeFitsQuorum]

Make Sense! Fixed!