HDDS-14729. Address followup items in HDDS-14646

[sodonnel]

What changes were proposed in this pull request?

Address the left over comments from #9779 -

Remove unused methods:
SCMUpgradeFinalizationContext#getConfiguration
SCMUpgradeFinalizationContext#getLayoutVersionManager
SCMUpgradeFinalizationContext#getPipelineManager

Nits in TestHddsUpgradeUtils.java

Note that the change to dsm.getContainer().getContainerSet().containerCount(); cannot be made, as getContainerSet() in this instance doesn't return a set, but an iterator() and there is no count method available.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14729

How was this patch tested?

Existing tests.

[Gargi-jais11]

Thanks @sodonnel for the patch. Found few more leftover dead codes.

[Gargi-jais11]

Nit: multiple backspaces.

[Gargi-jais11]

I think we should consider removing conf from Builder ? Since nothing in FinalizationManagerImpl reads or uses it. It’s effectively dead.

The Builder still has:

• private OzoneConfiguration conf;
• setConfiguration(OzoneConfiguration configuration)
• Objects.requireNonNull(conf, "conf == null") in build()
  and corresponding to that StorageContainerManager still calls .setConfiguration(conf) when building the FinalizationManagerImpl.

[sodonnel]

I had removed this in an earlier version I reset and missed it on the second pass. I will remove it.

[Gargi-jais11]

Consider removing this PipelineManager as it only called in inorder as it is no longer used in SCM finalization (it was removed from the builder upgrade context), so it’s dead code in the test and can be removed.

[sodonnel]

Yea, good point. I have removed it and the tests are passing locally at least.

[errose28]

Note that the change to dsm.getContainer().getContainerSet().containerCount(); cannot be made, as getContainerSet() in this instance doesn't return a set, but an iterator() and there is no count method available.

Looks like you're referring to dsm.getContainer().getController().getContainers(), which is the call that was originally being used. Switching to dsm.getContainer().getContainerSet().containerCount() does produce an int.