libs/libc/pthread: Optimize mutex robustness configuration and remove unnecessary tl_lock

[hujun260]

Summary

This pull request optimizes NuttX pthread mutex implementation by:

1. Removing unnecessary tl_lock: Analysis shows the per-thread mutex lock is redundant as TLS operations have no intra-thread conflicts
2. Changing default mutex robustness: Makes PTHREAD_MUTEX_DEFAULT_UNSAFE the default configuration when CONFIG_PTHREAD_MUTEX_BOTH is enabled

These changes improve performance, reduce memory overhead, and simplify synchronization logic without compromising safety.

Changes Made

Commit 1: Remove tl_lock

• Remove tl_lock field from struct tls_info_s
• Remove lock operations from pthread_mutex_add() and pthread_mutex_remove()
• Remove lock operations from pthread_mutex_inconsistent()
• Remove lock initialization/destruction in TLS management
• Rationale: Each thread exclusively owns its TLS; no intra-thread conflicts exist

Commit 2: Change Default Mutex Robustness

• Change default from PTHREAD_MUTEX_DEFAULT_ROBUST to PTHREAD_MUTEX_DEFAULT_UNSAFE
• Inline pthread_mutex_add/remove functions to optimize hot paths
• Conditionally track mutexes only for ROBUST mutexes
• Rationale: Reflects practical default, simplifies code for non-robust mutexes

Impact

• Performance:

  • Eliminates lock overhead in mutex operations (Commit 1)
  • Enables function inlining for performance-critical paths (Commit 2)
  • Reduces TLS access overhead for unsafe mutexes (Commit 2)

• Memory:

  • Removes one mutex_t per thread (~sizeof(mutex_t) bytes per thread)
  • Reduces code complexity in mutex management

• Compatibility:

  • Fully backward compatible
  • Applications explicitly specifying mutex robustness are unaffected
  • Default configurations optimized for common use case

Files Modified

Core Synchronization (Commit 1):

• include/nuttx/tls.h - Remove tl_lock field
• libs/libc/pthread/pthread_mutex.c - Remove lock operations
• sched/pthread/pthread_mutexinconsistent.c - Remove lock operations
• sched/sched/sched_releasetcb.c - Remove lock destruction
• sched/tls/tls_dupinfo.c - Remove lock initialization
• sched/tls/tls_initinfo.c - Remove lock initialization

Configuration (Commit 2):

• libs/libc/pthread/pthread_mutex.c - Inline functions, conditional tracking
• sched/Kconfig - Change default robustness mode

Technical Justification

Why is tl_lock unnecessary?

1. Single-threaded per-thread access: Each thread owns exactly one TLS structure
2. No cross-thread interference: Operations on tls->tl_mhead have no intra-thread conflicts
3. Safe call context: pthread_mutex_inconsistent called only during task exit

Why change default to UNSAFE?

1. Practical default: Most applications don't require robust mutexes
2. Performance optimization: Eliminates tracking overhead for typical use cases
3. Explicit control: Applications can still request robust behavior when needed
4. Simplification: Reduces code paths in performance-critical mutex operations

Testing Procedures

1. Functionality Tests:

   • Run ostest and pthreadtest to verify normal operation
   • Test both robust and unsafe mutex modes
   • Verify mutex inheritance and inconsistency handling

2. Performance Tests:

   • Measure mutex acquisition time (should improve or stay stable)
   • Measure thread creation overhead (should improve)
   • Profile TLS operation latency

3. Stress Tests:

   • Multi-threaded workloads with mutex contention
   • Thread creation/destruction cycles
   • Mutex inconsistency scenarios

4. Configuration Tests:

   • Test with CONFIG_PTHREAD_MUTEX_ROBUST only
   • Test with CONFIG_PTHREAD_MUTEX_UNSAFE only
   • Test with CONFIG_PTHREAD_MUTEX_BOTH (default=UNSAFE)

Verification Checklist

• Code builds without warnings or errors
• All pthread tests pass successfully
• No race conditions or deadlocks introduced
• Memory footprint improved (tl_lock removed)
• Performance metrics show improvement or stability
• No functional regression in mutex operations
• TLS initialization and cleanup work correctly
• Configuration changes applied correctly
• Backward compatibility maintained

Related Changes

This optimization series improves pthread synchronization by:

• Removing unnecessary locking mechanisms
• Optimizing for common use cases
• Maintaining safety where needed

[xiaoxiang781216]

@hujun260 please fix the conflict

[hujun260]

@hujun260 please fix the conflict

ok

fixed