Skip to content

testing: fix compilation issues with missing header files#3358

Merged
xiaoxiang781216 merged 5 commits intoapache:masterfrom
txy-21:testing-header-fixes
Jan 26, 2026
Merged

testing: fix compilation issues with missing header files#3358
xiaoxiang781216 merged 5 commits intoapache:masterfrom
txy-21:testing-header-fixes

Conversation

@txy-21
Copy link
Contributor

@txy-21 txy-21 commented Jan 21, 2026

Summary

This PR fixes multiple compilation issues in testing and netutils modules by adding missing POSIX header files. These changes ensure proper compilation across different platforms and build configurations.

Changes

This PR includes 5 commits addressing header file dependencies:

  1. testing/testsuites: Add malloc.h for fstest.h - fixes memory allocation function declarations
  2. netutils/system: Add missing headers in md5.c, ftpd.c, and lsan - ensures proper POSIX API availability
  3. testing: Add unistd.h and pthread.h to test modules - fixes POSIX function and threading API dependencies
  4. testing/drivers: Add unistd.h for touchpanel driver test - provides POSIX system call declarations
  5. netutils/rexecd: Fix pointer-to-integer type cast warning - eliminates compiler warning on 64-bit systems

Files Modified

  • testing/testsuites/kernel/fs/include/fstest.h - Added malloc.h
  • netutils/codecs/md5.c - Added missing header
  • netutils/ftpd/ftpd.c - Added missing header
  • system/lsan/lsan_main.c - Added missing header
  • testing/mm/memstress/memorystress_main.c - Added unistd.h and pthread.h
  • testing/drivers/crypto/dhm.c - Added unistd.h
  • testing/mm/cachetest/cachetest_main.c - Added unistd.h
  • testing/drivers/drivertest/drivertest_touchpanel.c - Added unistd.h
  • netutils/rexecd/rexecd.c - Fixed type cast issue

Impact

  • Stability: Fixes compilation failures on platforms with strict header requirements
  • Compatibility: Ensures POSIX compliance across different toolchains
  • Code Quality: Eliminates compiler warnings related to implicit function declarations
  • Breaking Changes: None - these are build fixes only, no functional changes

Testing

Test Environment

  • Host: Linux x86_64 (Ubuntu 22.04)
  • Toolchain: GCC 11.4.0 / Clang 14.0
  • Configurations: sim:nsh, sim:ostest

Test Steps

  1. Built affected modules with various configurations
  2. Verified no compilation errors or warnings
  3. Ran existing test suites to confirm no regressions
  4. Cross-compiled for ARM and RISC-V targets

Test Results

# Compilation test
$ make distclean && ./tools/configure.sh sim:nsh
$ make -j$(nproc)
✅ Build completed successfully with no errors
✅ No new warnings introduced

# Runtime test
$ ./nuttx
NuttShell (NSH) NuttX-12.x
nsh> ostest
✅ All tests passed

@xiaoxiang781216
Copy link
Contributor

@txy-21 please fix:

/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:143: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:145: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:147: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:245: ALLO ==> ALLOW
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:245: ALLO ==> ALLOW
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:264: ALLO ==> ALLOW
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2148: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2157: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2370: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2387: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2415: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2435: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2457: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2465: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3420: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3438: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3439: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3454: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3472: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3473: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/mm/memstress/memorystress_main.c:125: debuger ==> debugger
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/mm/memstress/memorystress_main.c:220: debuger ==> debugger

@txy-21 txy-21 force-pushed the testing-header-fixes branch 3 times, most recently from 179bcc6 to 12bba70 Compare January 21, 2026 11:45
@txy-21 txy-21 closed this Jan 21, 2026
@txy-21 txy-21 reopened this Jan 21, 2026
@txy-21
Copy link
Contributor Author

txy-21 commented Jan 21, 2026

@txy-21 please fix:

/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:143: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:145: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:147: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:245: ALLO ==> ALLOW
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:245: ALLO ==> ALLOW
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:264: ALLO ==> ALLOW
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2148: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2157: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2370: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2387: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2415: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2435: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2457: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:2465: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3420: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3438: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3439: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3454: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3472: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/ftpd/ftpd.c:3473: opton ==> option
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/mm/memstress/memorystress_main.c:125: debuger ==> debugger
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/mm/memstress/memorystress_main.c:220: debuger ==> debugger

@xiaoxiang781216 Done

hongfengchen-xiaomi and others added 4 commits January 26, 2026 14:09
Add malloc.h header file to fstest.h to fix missing malloc/free
function declarations in filesystem test suites.

Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
Add missing header files in netutils and lsan modules to fix
implicit function declarations and improve compilation compatibility.

Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
Add unistd.h and pthread.h for memorystress_main.c, unistd.h for
dhm.c and cachetest_main.c, and pthread.h for kv_test_019.c to fix
missing declarations.

Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
Add unistd.h header file to drivertest_touchpanel.c to fix missing
sleep/usleep function declarations in touchpanel driver tests.

Signed-off-by: tengshuangshuang <tengshuangshuang@xiaomi.com>
@txy-21 txy-21 force-pushed the testing-header-fixes branch from 325b143 to f335f08 Compare January 26, 2026 06:12
Fix cast from pointer to integer of different size to ensure
proper type conversion and avoid compilation warnings.

Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
@txy-21 txy-21 force-pushed the testing-header-fixes branch from f335f08 to a6dad89 Compare January 26, 2026 06:18
@xiaoxiang781216 xiaoxiang781216 merged commit c69df55 into apache:master Jan 26, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants