testing/cmocka: stdio.h Header file adjustment related#2852
testing/cmocka: stdio.h Header file adjustment related#2852anjiahao1 wants to merge 1 commit intoapache:masterfrom
Conversation
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a link to the PR and mentions Here's what's missing:
The provided link to the PR is helpful, but the PR description itself needs to be self-contained and meet all the listed requirements. Relying on reviewers to click through to another page to gather essential information is not good practice. |
Error: cmocka/src/cmocka.c:2568:9: error: implicit declaration of function 'ftruncate'; did you mean 'strncat'? [-Werror=implicit-function-declaration]
2568 | ftruncate(fileno(fp), ftell(fp));
| ^~~~~~~~~
| strncat
Signed-off-by: anjiahao <[email protected]>
| ${CMAKE_CURRENT_LIST_DIR}/0005-cmocka-cmocka_private-fix-warning-in-cmocka_private.patch | ||
| && patch -p0 -d ${CMAKE_CURRENT_LIST_DIR}/cmocka < | ||
| ${CMAKE_CURRENT_LIST_DIR}/0006-fix-linux-risc-v-compile-error-list_initialize.patch | ||
| && patch -p0 -d ${CMAKE_CURRENT_LIST_DIR}/cmocka < |
There was a problem hiding this comment.
but no compiler error happen in cmocka:
https://github.com/apache/nuttx/actions/runs/11834392207/job/32975068050?pr=14697
There was a problem hiding this comment.
i test in linux, ftruncate is need include <unistd.h>. ftruncate is not use in cmocka mainline
There was a problem hiding this comment.
let's update to cmocka new version instead
cederom
changed the title
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @anjiahao1 :-)
- Please update git commit topic and message.
- Should this PR go in pair with apache/nuttx#14697 or is it independent update?
|
@anjiahao1 any updates on this PR? |
5 participants
Summary
testing/cmockaadd patch to fix missing headers.Impact
Testing
sim:citest build