-
Notifications
You must be signed in to change notification settings - Fork 2.9k
NIFI-13125 - Flow Version Diff View #10473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
010fc08 to
d1ff571
Compare
scottyaslan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. I have left some comments. I am happy to review and help iterate here and continue to improve the UX for this feature.
.../app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.ts
Outdated
Show resolved
Hide resolved
...pp/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html
Outdated
Show resolved
Hide resolved
...pp/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.scss
Outdated
Show resolved
Hide resolved
...nifi/src/app/pages/flow-designer/ui/canvas/items/flow/flow-diff-dialog/flow-diff-dialog.html
Outdated
Show resolved
Hide resolved
...nifi/src/app/pages/flow-designer/ui/canvas/items/flow/flow-diff-dialog/flow-diff-dialog.html
Outdated
Show resolved
Hide resolved
...s/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/flow-diff-dialog/flow-diff-dialog.ts
Outdated
Show resolved
Hide resolved
...nifi/src/app/pages/flow-designer/ui/canvas/items/flow/flow-diff-dialog/flow-diff-dialog.html
Show resolved
Hide resolved
...nifi/src/app/pages/flow-designer/ui/canvas/items/flow/flow-diff-dialog/flow-diff-dialog.html
Outdated
Show resolved
Hide resolved
...s/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/flow-diff-dialog/flow-diff-dialog.ts
Outdated
Show resolved
Hide resolved
...s/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/flow-diff-dialog/flow-diff-dialog.ts
Outdated
Show resolved
Hide resolved
|
Thanks for all the feedback @scottyaslan - highly appreciated! I have (hopefully) made the changes you had in mind. The only thing that is not ok is the timestamp in the dropdown lists when selecting versions. Will figure it out tomorrow. It looks so much better now, thanks for all of the review comments!
|




Summary
NIFI-13125 - Flow Version Diff View
I used #9109 as a starting point and coded something similar for NiFi 2.x. Definitely not a UI expert so my approach may not be the best one. Happy to collaborate with someone more experienced on the UI side.
This feature is particularly useful when a user sees that a versioned process group can be updated to a new version and the user would like to see what are the differences with the current version before upgrading the process group.
Access to the view is made available when listing versions for a versioned process group:
Clicking on the diff icon for the desired version will show the diff between the current version and the selected version
Versions can be selected via the dropdown lists:
Filtering is also possible to filter the content of the table, and the columns can also be sorted alphabetically.
The current feature does not allow comparison across branches but that could be considered as a follow-up improvement if the community sees value into it (I'm not sure I picture a use case where it would be very useful).
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation