Skip to content

MINIFICPP-2753 - Remove restore from c-api#2141

Open
adamdebreceni wants to merge 1 commit intoapache:mainfrom
adamdebreceni:MINIFICPP-2753
Open

MINIFICPP-2753 - Remove restore from c-api#2141
adamdebreceni wants to merge 1 commit intoapache:mainfrom
adamdebreceni:MINIFICPP-2753

Conversation

@adamdebreceni
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@szaszm
Copy link
Member

szaszm commented Mar 23, 2026

why?

@martinzink
Copy link
Member

why?

I can answer that, this fn is only used for niche usages and kinda hacky (storing flowfiles in the self relationship for later use). This features is only used by 4 processors (MergeContent, DefragmentText, ListenHTTP, PushGrafanaLoki), and I feel like this could be done cleaner so its better not to commit to this architecture in the first release of the C API. (hopefully we can think of something better or if we cant we can easily add this later without breaking the API)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants