Skip to content

Conversation

@BradWalker
Copy link
Member

cleanup: cleanup usage of getSecurityManager()

desc: getSecurityManager() is deprecated and marked for imminent removal. In addition as of JDK 24, getSecurityManager() returns null.

This change removes getSecurityManager() from various places that have minimal impact.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@BradWalker BradWalker added this to the NB29 milestone Dec 23, 2025
@BradWalker BradWalker self-assigned this Dec 23, 2025
@BradWalker BradWalker added the Code cleanup Label for cleanup done on the Netbeans IDE label Dec 23, 2025
desc: getSecurityManager() is deprecated and marked for imminent removal. In addition as of JDK 24, getSecurityManager() returns null.

This change removes getSecurityManager() from various places that have minimal impact.
@BradWalker BradWalker force-pushed the cleanup_securitymanager_usage branch from b355a3e to f6e3eff Compare December 23, 2025 05:40
@mbien
Copy link
Member

mbien commented Dec 23, 2025

some filesystem tests (possibly others too) still rely on the SM to intercept events. Please add the all-tests label and make sure everything is green when you do cleanups across clusters or in core functionality.

@BradWalker BradWalker added the ci:all-tests [ci] enable all tests label Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:all-tests [ci] enable all tests Code cleanup Label for cleanup done on the Netbeans IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants