Preventing an NPE for compact source files inside test roots.#9003
Merged
lahodaj merged 1 commit intoapache:masterfrom Jan 7, 2026
Merged
Preventing an NPE for compact source files inside test roots.#9003lahodaj merged 1 commit intoapache:masterfrom
lahodaj merged 1 commit intoapache:masterfrom
Conversation
mbien
approved these changes
Nov 11, 2025
Contributor
|
@lahodaj and this is another merge candidate. I think it makes sense to finish these by merging them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a compact source file inside a test root, there's an NPE:
The reason is that the synthetic wrapper class does not have a name span (i.e. has
null).The proposal herein is to simply avoid the problems with a null check, and using the class' starting position instead of the name position.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)