Skip to content

Fixed the quote problem in "as" clause in view && Fixed the bug that the device may not be able to be queried from cache#17241

Merged
Caideyipi merged 2 commits intomasterfrom
fix-quote
Mar 4, 2026
Merged

Fixed the quote problem in "as" clause in view && Fixed the bug that the device may not be able to be queried from cache#17241
Caideyipi merged 2 commits intomasterfrom
fix-quote

Conversation

@Caideyipi
Copy link
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 14.28571% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.69%. Comparing base (b224633) to head (af1a64a).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...yengine/plan/relational/sql/parser/AstBuilder.java 0.00% 14 Missing ⚠️
...lational/sql/ast/AbstractQueryDeviceWithCache.java 0.00% 10 Missing ⚠️
...plan/node/metadata/read/DevicesSchemaScanNode.java 33.33% 6 Missing ⚠️
...nal/metadata/fetcher/TableDeviceSchemaFetcher.java 0.00% 4 Missing ⚠️
...config/metadata/relational/ShowCreateViewTask.java 0.00% 1 Missing ⚠️
...ueryengine/plan/planner/OperatorTreeGenerator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #17241   +/-   ##
=========================================
  Coverage     39.69%   39.69%           
  Complexity      282      282           
=========================================
  Files          5102     5102           
  Lines        342026   341994   -32     
  Branches      43574    43565    -9     
=========================================
- Hits         135778   135770    -8     
+ Misses       206248   206224   -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi Caideyipi merged commit 19d7670 into master Mar 4, 2026
28 of 30 checks passed
@Caideyipi Caideyipi deleted the fix-quote branch March 4, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant