perf(reader): Implement AsyncFileReader get_byte_ranges and coalesce close ranges#2181
Merged
blackmwk merged 9 commits intoapache:mainfrom Mar 6, 2026
Merged
perf(reader): Implement AsyncFileReader get_byte_ranges and coalesce close ranges#2181blackmwk merged 9 commits intoapache:mainfrom
blackmwk merged 9 commits intoapache:mainfrom
Conversation
mbutrovich
changed the title
Collaborator
Author
|
I ran
Histogram of S3 GET sizes: |
mbutrovich
changed the title
CTTY
approved these changes
Mar 2, 2026
Collaborator
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the this change!
blackmwk
reviewed
Mar 5, 2026
15 tasks
blackmwk
approved these changes
Mar 6, 2026
Contributor
blackmwk
left a comment
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @mbutrovich for this pr!
| row_group_filtering_enabled: true, | ||
| row_selection_enabled: false, | ||
| metadata_size_hint: None, | ||
| parquet_read_options: ParquetReadOptions::builder().build(), |
Contributor
There was a problem hiding this comment.
nit: We could implement a Default for ParquetReadOptions.
This was referenced Mar 6, 2026
gbrgr
pushed a commit
to RelationalAI/iceberg-rust
that referenced
this pull request
Mar 10, 2026
…close ranges (apache#2181) <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Partially address apache#2172. <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> - Adapt range coalescing from object_store. <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Existing tests, some new ones just to sanity check `merge_ranges`. Also ran full Iceberg Java suite via Comet. Benchmarks below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
Existing tests, some new ones just to sanity check
merge_ranges. Also ran full Iceberg Java suite via Comet. Benchmarks below.