feat(transaction): RewriteFilesAction + Validation Support + Process Delete Manifests#1606
Draft
CTTY wants to merge 22 commits intoapache:mainfrom
Draft
feat(transaction): RewriteFilesAction + Validation Support + Process Delete Manifests#1606CTTY wants to merge 22 commits intoapache:mainfrom
RewriteFilesAction + Validation Support + Process Delete Manifests#1606CTTY wants to merge 22 commits intoapache:mainfrom
Conversation
This was referenced Aug 15, 2025
Sl1mb0
reviewed
Nov 4, 2025
Sl1mb0
reviewed
Nov 4, 2025
Sl1mb0
reviewed
Nov 4, 2025
|
|
||
| for entry in manifest.entries() { | ||
| match entry.content_type() { | ||
| DataContentType::Data => { |
Contributor
There was a problem hiding this comment.
These are the exact same code blocks? So why does the ManifestEntry's DataContentType matter? Why not just do:
for entry in manifest.entries() {
if snapshot_producer
.deleted_data_files
.iter()
.any(|f| f.file_path == entry.data_file.file_path())
{
delete_entries.push(copy_with_deleted_status())
}
}
Collaborator
Author
There was a problem hiding this comment.
It looks very similar with one little difference: one block iterates thru deleted_data_files and another iterates thru deleted_delete_files
CTTY
force-pushed
the
ctty/pure-rewrite
branch
from
71a696f to
336c974
Compare
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RewriteFilessupport to iceberg-rust #1607What changes are included in this PR?
RewriteFilesActionSnapshotValidatorand implemented it forRewriteFilesOperationSnapshotProducerand generate manifestsAre these changes tested?
Not tested so far