Skip to content

Switch to uv-pre-commit for lockfile management #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geruh merged 2 commits into from
Mar 12, 2026
+6 −16
Merged

Switch to uv-pre-commit for lockfile management #3141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72af28c
replace w/ uv-pre-commit
kevinjqliu Mar 11, 2026
c223f03
newline
kevinjqliu Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,9 @@ repos:
rev: v2.4.1
hooks:
- id: codespell
- repo: local
- repo: https://github.com/astral-sh/uv-pre-commit
# uv version.
rev: 0.10.9
hooks:
- id: uv-lock-check
name: uv lock file check
entry: make uv-lock-check
language: system
pass_filenames: false
files: ^(pyproject\.toml|uv\.lock)$
# Update the uv lockfile
- id: uv-lock
Copy link
Contributor

@nssalian nssalian Mar 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this updates and checks, that's great, else we might have to restore the makefile: https://docs.astral.sh/uv/guides/integration/pre-commit/ just says checks if up to date so @raulcd's comment is worth looking at by testing locally.

10 changes: 1 addition & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
test test-integration test-integration-setup test-integration-exec test-integration-cleanup test-integration-rebuild \
test-s3 test-adls test-gcs test-coverage coverage-report \
docs-serve docs-build notebook notebook-infra \
clean uv-lock uv-lock-check
clean

.DEFAULT_GOAL := help
# ========================
Expand Down Expand Up @@ -193,11 +193,3 @@ clean: ## Remove build artifacts and caches
@echo "Cleaning up coverage files..."
@rm -rf .coverage .coverage.* htmlcov/ coverage.xml
@echo "Cleanup complete."

uv-lock: ## Regenerate uv.lock file from pyproject.toml
uv lock $(PYTHON_ARG)
Copy link
Member

@geruh geruh Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call on the remove, uv.lock should be version agnostic


uv-lock-check: ## Verify uv.lock is up to date
@command -v uv >/dev/null || \
(echo "uv is required. Run 'make install' or 'make install-uv' first." && exit 1)
uv lock --check $(PYTHON_ARG)
Loading