HIVE-13748: Support hyphen(-) in struct field names in TypeInfoUtils#6329
Open
saitharun15 wants to merge 1 commit intoapache:masterfrom
Open
HIVE-13748: Support hyphen(-) in struct field names in TypeInfoUtils#6329saitharun15 wants to merge 1 commit intoapache:masterfrom
saitharun15 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Contributor
|
I believe my pull request is a little more generic and can cover a hyphen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, TypeInfoUtils rejects struct field names containing hyphens (for example,
aws-region) during type parsing and throws an exception.Related JIRA issues: HIVE-13748 HIVE-24181 HIVE-20272
Why are the changes needed?
Tables backed by Hadoop catalogs can be created with struct field names containing hyphens. However, the same schemas fail during type parsing when using Hive-backed catalogs.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added Unit Test