HBASE-29958 Improve log messages#7922
HBASE-29958 Improve log messages#7922sharmaar12 wants to merge 19 commits intoapache:HBASE-29081_rebasedfrom
Conversation
(cherry picked from commit 7ab9d52)
anmolnar
left a comment
anmolnar
left a comment
There was a problem hiding this comment.
lgtm. A quick question.
| } catch (DeserializationException e) { | ||
| LOG.error("Failed to deserialize ActiveClusterSuffix from file {}", activeClusterFile, e); |
There was a problem hiding this comment.
I'm not sure about catching the exception here. We just log the error and proceed. Isn't that a problem?
There was a problem hiding this comment.
@anmolnar I believe we just log the error for any of these exception is because the cluster is read only which means it is expected to delete the file if it exists and cluster is the owner of that file, but if the file does not exists or it is not the owner then we can safely ignore it, because for read-only we are not mutating any data so safe to start the cluster.
Similarly I think if we can't deserialize it then deletion will not happen, but cluster can start in read-only mode. Anyways this case needs manual intervention because of cluster ID file corruption.
…s.java Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>
…s.java Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>
…erFileSystem.java Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>
sharmaar12
force-pushed
the
log-message_rebase
branch
from
5b78ce6 to
3717463
Compare
anmolnar
force-pushed
the
HBASE-29081_rebased
branch
from
520b89a to
5d47ec9
Compare
3 participants
No description provided.