HBASE-29960 java.lang.IllegalStateException: Should not call create writer on secondary replicas or in read-only mode#7899
Open
sharmaar12 wants to merge 1 commit intoapache:HBASE-29081from
Conversation
…riter on secondary replicas or in read-only mode
anmolnar
requested changes
Mar 10, 2026
Contributor
anmolnar
left a comment
anmolnar
left a comment
There was a problem hiding this comment.
One comment only, otherwise looks good to me.
Important to note that we've changed our original approach with this patch and now every table remains writable in "hbase" and "master" namespaces.
| public final StoreFileWriter createWriter(CreateStoreFileWriterParams params) throws IOException { | ||
| if (!isPrimaryReplica || isReadOnlyEnabled()) { | ||
| if ( | ||
| !isPrimaryReplica || (isReadOnlyEnabled() && !ctx.getTableName().isWritableInReadOnlyMode()) |
Contributor
There was a problem hiding this comment.
What about the other methods in this class? load(), add(), replace(), set()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.