HBASE-29878 Add missing footnotes (addendum)#7878
Merged
PDavid merged 5 commits intoapache:masterfrom Mar 9, 2026
Merged
Conversation
PDavid
reviewed
Mar 6, 2026
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/upgrading/version-number.mdx
Outdated
Show resolved
Hide resolved
PDavid
approved these changes
Mar 6, 2026
Contributor
PDavid
left a comment
PDavid
left a comment
There was a problem hiding this comment.
Many thanks! 👍
Special thanks for extending the documentation and the tests! 💪
guluo2016
reviewed
Mar 7, 2026
| [^1]: Running an offline upgrade tool without downgrade might be needed. We will typically only support migrating data from major version X to major version X+1. | ||
| [^1]: See 'Source Compatibility' https://wiki.openjdk.org/spaces/csr/pages/32342052/Kinds+of+Compatibility | ||
|
|
||
| [^2]: See http://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html. |
Member
There was a problem hiding this comment.
As I mentioned here https://issues.apache.org/jira/browse/HBASE-29957?filter=12352185#:~:text=Additionally%2C%20I%20noticed,8%20or%2017)%EF%BC%9F,
The link we are using is for Java SE 7. Isn't this version a bit outdated?
I suggest updating it to SE 8. What do you think? @PDavid @yuriipalam
Contributor
There was a problem hiding this comment.
Thanks, I think this makes perfect sense. 👍
liuxiaocs7
approved these changes
Mar 8, 2026
yuriipalam
commented
Mar 9, 2026
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/upgrading/version-number.mdx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new docs had some missing footnotes, this PR adds them back. Also, I added some testing to ensure the uniqueness of all reference ids across all the files.