HBASE-29831 Fix for NPE in region replication (branch-2.5 backport) by krconv · Pull Request #7684 · apache/hbase

krconv · 2026-01-28T16:28:33Z

Backport to branch-2.5 for PR #7629

Signed-off-by: Chandra Kambham <chandra@apache.org> Signed-off-by: Peng Lu <lupeng@apache.org>

Apache-HBase · 2026-01-28T17:20:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 25s		branch-2.5 passed
+1 💚	compile	2m 55s		branch-2.5 passed
+1 💚	checkstyle	0m 39s		branch-2.5 passed
+1 💚	spotbugs	1m 35s		branch-2.5 passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	2m 53s		the patch passed
+1 💚	javac	2m 53s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		the patch passed
+1 💚	spotbugs	1m 41s		the patch passed
+1 💚	hadoopcheck	22m 39s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.1.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		44m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7684
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux f2735bfd5b41 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `d89b861`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-28T20:03:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 36s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 36s		branch-2.5 passed
+1 💚	compile	0m 43s		branch-2.5 passed
+1 💚	javadoc	0m 23s		branch-2.5 passed
+1 💚	shadedjars	4m 30s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 21s		the patch passed
+1 💚	compile	0m 46s		the patch passed
+1 💚	javac	0m 46s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed
+1 💚	shadedjars	4m 28s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	185m 47s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		207m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7684
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6c4c977ce6b2 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `d89b861`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/testReport/
Max. process+thread count	3977 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-28T20:21:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 45s		branch-2.5 passed
+1 💚	compile	0m 44s		branch-2.5 passed
+1 💚	javadoc	0m 27s		branch-2.5 passed
+1 💚	shadedjars	5m 11s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 26s		the patch passed
+1 💚	compile	0m 42s		the patch passed
+1 💚	javac	0m 42s		the patch passed
+1 💚	javadoc	0m 24s		the patch passed
+1 💚	shadedjars	5m 7s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	202m 5s		hbase-server in the patch passed.
		225m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7684
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux fda9150ca05a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `d89b861`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/testReport/
Max. process+thread count	2994 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-28T20:24:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 23s		branch-2.5 passed
+1 💚	compile	0m 50s		branch-2.5 passed
+1 💚	javadoc	0m 28s		branch-2.5 passed
+1 💚	shadedjars	6m 1s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 51s		the patch passed
+1 💚	compile	0m 47s		the patch passed
+1 💚	javac	0m 47s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	5m 56s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	202m 30s		hbase-server in the patch passed.
		228m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7684
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 8e1792e05cd2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `d89b861`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/testReport/
Max. process+thread count	3139 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7684/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

guluo2016 · 2026-01-29T16:18:51Z

There is a test case failed (org.apache.hadoop.hbase.regionserver.TestClearRegionBlockCache.testClearBlockCache[1: bucket]), but it’s unrelated to this PR.
let me take a look at this error first.

guluo2016

Thanks!

guluo2016 · 2026-01-30T14:51:05Z

.../java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java

          // they come online.
          if (useCache && locations.size() == 1 && TableName.isMetaTableName(tableName)) {
-            if (tableDescriptors.get(tableName).getRegionReplication() > 1) {
+            TableDescriptor td = tableDescriptors.get(tableName);


Sorry, I just noticed a few additional concerns after approving
I found the issue doesn't seem to exist for branch-2.5.
The code is only executed when seCache && locations.size() == 1 && TableName.isMetaTableName(tableName) is true, whch means that it's meta table, and the td of meta table is not null in here . right ? @krconv

Oh I see; agreed it doesn't seem to apply here. Thank you for finding that! I'll close this.

HBASE-29831 Fix for NPE in region replication (apache#7629)

d89b861

Signed-off-by: Chandra Kambham <chandra@apache.org> Signed-off-by: Peng Lu <lupeng@apache.org>

krconv changed the title ~~HBASE-29831 Fix for NPE in region replication (#7629)~~ HBASE-29831 Fix for NPE in region replication (branch-2.5 backport) Jan 28, 2026

krconv mentioned this pull request Jan 28, 2026

HBASE-29831: Fix for NPE in region replication #7629

Merged

guluo2016 approved these changes Jan 30, 2026

View reviewed changes

guluo2016 reviewed Jan 30, 2026

View reviewed changes

krconv closed this Feb 2, 2026

krconv deleted the HBASE-29831-read-replicas-npe-branch-2.5 branch February 2, 2026 11:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-29831 Fix for NPE in region replication (branch-2.5 backport)#7684

HBASE-29831 Fix for NPE in region replication (branch-2.5 backport)#7684
krconv wants to merge 1 commit intoapache:branch-2.5from
HubSpot:HBASE-29831-read-replicas-npe-branch-2.5

krconv commented Jan 28, 2026 •

edited

Loading

Uh oh!

Apache-HBase commented Jan 28, 2026

Uh oh!

Apache-HBase commented Jan 28, 2026

Uh oh!

Apache-HBase commented Jan 28, 2026

Uh oh!

Apache-HBase commented Jan 28, 2026

Uh oh!

guluo2016 commented Jan 29, 2026

Uh oh!

guluo2016 left a comment

Uh oh!

guluo2016 Jan 30, 2026

Uh oh!

krconv Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

krconv commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Jan 28, 2026

Uh oh!

Apache-HBase commented Jan 28, 2026

Uh oh!

Apache-HBase commented Jan 28, 2026

Uh oh!

Apache-HBase commented Jan 28, 2026

Uh oh!

guluo2016 commented Jan 29, 2026

Uh oh!

guluo2016 left a comment

Choose a reason for hiding this comment

Uh oh!

guluo2016 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

krconv Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krconv commented Jan 28, 2026 •

edited

Loading