-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29837 Backport HBASE-27355 Separate meta read requests from master and client (#7261) #7652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-2
Are you sure you want to change the base?
Conversation
…e#7261) Co-authored-by: huiruan <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Aman Poonia <[email protected]>
| public static final int HIGH_QOS = 200; | ||
| public static final int SYSTEMTABLE_QOS = HIGH_QOS; | ||
| // QOS for internal meta read requests | ||
| public static final int INTERNAL_READ_QOS = 250; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought of another approch where we can define INTERNAL_READ_QOS in AnnotationReadingPriorityFunction (hbase-server module) and then let the master pass the priority while requesting to MetaTableAccessor, but that way we would end up doing many changes.
|
@frostruan , @Apache9 , @mnpoonia please review. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Same tests, TestSecureIPC, were passing in the previous build. So I think we can ignore Test failure. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Because, MetaTableAccessor moved to hbase-server in master/branch-3 in HBASE-24609 and HBASE-25758, cherry-pick of HBASE-27355 was not clean.
This is an important improvement and I think needed in 2.x as well.