HBASE-29733 Use ServerName instead of hostname in unloadRegions log message#7487
Open
jcongithub wants to merge 2 commits intoapache:masterfrom
Open
HBASE-29733 Use ServerName instead of hostname in unloadRegions log message#7487jcongithub wants to merge 2 commits intoapache:masterfrom
jcongithub wants to merge 2 commits intoapache:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Hi @jcongithub, Thanks for your contribution. Please also update the PR title to start with the Jira ticket ID. |
b922d09 to
3b4b0cb
Compare
Author
|
Thanks @PDavid |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
guluo2016
reviewed
Jan 8, 2026
| } | ||
| LOG.info("Moving {} regions from {} to {} servers using {} threads .Ack Mode: {}", | ||
| regionsToMove.size(), this.hostname, regionServers.size(), this.maxthreads, ack); | ||
| regionsToMove.size(), server, regionServers.size(), this.maxthreads, ack); |
Member
There was a problem hiding this comment.
For me is ok.
There are the same issues in other parts of this file as well. Could you update them together in this change?
For example, the log statement a few lines above has the same issue.
LOG.info("Putting server : " + server.getHostname() + " in decommission/draining mode");
admin.decommissionRegionServers(listOfServer, false);
pankaj72981
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnloadRegions log message uses the hostname to show where regions are unloading from. When a host runs multiple region servers, the hostname in the log message alone is insufficient to identify which specific region server is unloading regions.
This PR has the change to use ServerName in the log, making it easier to distinguish between region servers on the same host similar to loadRegions log message.
This PR also fixes a log statement