Skip to content

[FLINK-38815] Mask sensitive values in Pekko configuration logs#27784

Open
dataengineervishal wants to merge 2 commits intoapache:masterfrom
dataengineervishal:FLINK-38815-mask-sensitive-pekko-config
Open

[FLINK-38815] Mask sensitive values in Pekko configuration logs#27784
dataengineervishal wants to merge 2 commits intoapache:masterfrom
dataengineervishal:FLINK-38815-mask-sensitive-pekko-config

Conversation

@dataengineervishal
Copy link

This PR depends on https://issues.apache.org/jira/browse/FLINK-38815

What is the purpose of the change

This pull request fixes a security issue where sensitive values in the Pekko RPC configuration were logged in plain text.

The Pekko configuration is based on Typesafe Config and was directly logged, bypassing Flink’s existing masking logic. This change ensures that sensitive values (such as passwords and secrets) are masked before being logged.

Brief change log

  • Converted Pekko Config into a flat Map<String, String> using entrySet()
  • Reused ConfigurationUtils.hideSensitiveValues() to mask sensitive values
  • Updated debug logging to print masked configuration instead of raw config

Verifying this change

This change is already covered by existing tests.

Additionally, the fix was manually verified by enabling debug logging and confirming that sensitive fields such as key-password and trust-store-password are masked (replaced with ******) in the logs.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 18, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dataengineervishal dataengineervishal force-pushed the FLINK-38815-mask-sensitive-pekko-config branch from 2063fe5 to bc36a5b Compare March 18, 2026 22:38
@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Mar 19, 2026
@dataengineervishal dataengineervishal force-pushed the FLINK-38815-mask-sensitive-pekko-config branch from 5e0704f to b3ecdfa Compare March 19, 2026 09:19
@dataengineervishal
Copy link
Author

@XComp Can you please take a look and approve this?

Copy link
Contributor

@Samrat002 Samrat002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good

@dataengineervishal dataengineervishal force-pushed the FLINK-38815-mask-sensitive-pekko-config branch from 59f81a1 to 32c31f6 Compare March 20, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants