branch-4.0: [fix](search) inject MATCH_ALL_DOCS for multi-MUST_NOT queries in lucene mode #60891#61001
Closed
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Closed
branch-4.0: [fix](search) inject MATCH_ALL_DOCS for multi-MUST_NOT queries in lucene mode #60891#61001github-actions[bot] wants to merge 1 commit intobranch-4.0from
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
…ene mode (#60891) ### What problem does this PR solve? Related PR: #60814 Problem Summary: In search() lucene mode, when all terms in a boolean query are MUST_NOT (e.g., `NOT a AND NOT b` or `NOT a NOT b` with default_operator=AND), the query incorrectly returns all documents instead of returning all documents EXCEPT those matching the negated terms. Root cause: Lucene's BooleanQuery with only MUST_NOT clauses matches nothing (by design). ES handles this by injecting a MatchAllDocsQuery with SHOULD occur. Doris only handled the single-term MUST_NOT case but not multi-term all-MUST_NOT queries. Fix: After `applyLuceneBooleanLogic()`, detect if ALL terms are MUST_NOT and inject `MATCH_ALL_DOCS(SHOULD)` with `minimum_should_match=1`.
airborne12
force-pushed
the
auto-pick-60891-branch-4.0
branch
from
d60dc26 to
768e12b
Compare
Member
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #60891